Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix verticalitem icon not allowing to click item #2514

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

HellWolf93
Copy link
Collaborator

@HellWolf93 HellWolf93 commented Oct 31, 2022

fix: #2515

@commit-lint
Copy link

commit-lint bot commented Oct 31, 2022

Bug Fixes

  • fix verticalitem icon not allowing to click item (c2bd29b)
  • add icon to href variant (3acf83f)

Contributors

HellWolf93

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@github-actions
Copy link

github-actions bot commented Oct 31, 2022

Visit the preview URL for this PR (updated for commit 3acf83f):

https://react-rainbow--pr2514-fix-verticalitem-ico-uxjjn6tj.web.app

(expires Mon, 07 Nov 2022 01:51:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2de6d670498a0a515484c5637b13d0215372df83

@codeclimate
Copy link

codeclimate bot commented Oct 31, 2022

Code Climate has analyzed commit 3acf83f and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

View more on Code Climate.

@LeandroTorresSicilia LeandroTorresSicilia merged commit 4148b22 into master Oct 31, 2022
@LeandroTorresSicilia LeandroTorresSicilia deleted the fix-verticalitem-icon branch October 31, 2022 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: vertical item to support click on icon
2 participants