Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currencyinput percentinput numeric keyboard mobile #2527

Conversation

adrianestevez1
Copy link
Contributor

fix: #2521

Changes proposed in this PR:

-fix: CurrencyInput and PercentInput must open a numeric keyboard in mobile devices
-fix: taking the constants out of the function in DateTimePicker component

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Nov 4, 2022

Bug Fixes

  • CurrencyInput and PercentInput must open a numeric keyboard in mobile devices (f17f808)
  • taking the constants out of the function in DateTimePicker component (63feb9c)

Contributors

LeandroTorresSicilia

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@CLAassistant
Copy link

CLAassistant commented Nov 4, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ LeandroTorresSicilia
❌ Adrian Estevez


Adrian Estevez seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Visit the preview URL for this PR (updated for commit 58dd012):

https://react-rainbow--pr2527-currencyinput-percen-sglzesim.web.app

(expires Sat, 12 Nov 2022 23:22:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2de6d670498a0a515484c5637b13d0215372df83

@codeclimate
Copy link

codeclimate bot commented Nov 5, 2022

Code Climate has analyzed commit 58dd012 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

View more on Code Climate.

@LeandroTorresSicilia LeandroTorresSicilia merged commit 2082319 into master Nov 5, 2022
@LeandroTorresSicilia LeandroTorresSicilia deleted the currencyinput-percentinput-numeric-keyboard-mobile branch November 5, 2022 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: CurrencyInput and PercentInput must open a numeric keyboard in mobile devices
3 participants