Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accordion component using setTimeout on componentDidMount in react 18 #2531

Conversation

yvmunayev
Copy link
Contributor

fix: #2530

Changes proposed in this PR:

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Nov 4, 2022

Bug Fixes

  • accordion component using setTimeout on componentDidMount in react 18 (baeea01)
  • some unit test error (0318269)

Contributors

yvmunayev, LeandroTorresSicilia

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Visit the preview URL for this PR (updated for commit d533596):

https://react-rainbow--pr2531-fix-components-using-8bnekfxx.web.app

(expires Sat, 12 Nov 2022 23:30:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2de6d670498a0a515484c5637b13d0215372df83

@yvmunayev yvmunayev changed the title Fix components using set timeout on component did mount in rect18 fix: accordion component using setTimeout on componentDidMount in react 18 Nov 4, 2022
@codeclimate
Copy link

codeclimate bot commented Nov 5, 2022

Code Climate has analyzed commit d533596 and detected 9 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 4
Duplication 5

View more on Code Climate.

@LeandroTorresSicilia LeandroTorresSicilia merged commit 38ea056 into master Nov 6, 2022
@LeandroTorresSicilia LeandroTorresSicilia deleted the fix-components-using-setTimeout-on-componentDidMount-in-rect18 branch November 6, 2022 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: accordion component using setTimeout on componentDidMount in react 18
2 participants