Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change border radius in popup menus of the inputables #2552

Conversation

yvmunayev
Copy link
Contributor

@yvmunayev yvmunayev commented Nov 27, 2022

fix: #2540
fix: #2542

Changes proposed in this PR:

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Nov 27, 2022

Bug Fixes

  • remove the "" around semi-square (c8f1695)
  • add example for the button icon (3f311c2)
  • change border radius in popup menus of the inputables (421799e)
  • change picklistOption with option component (785d6a3)

Chore

Features

  • add border radius prop to modal (a3e1a31)

Contributors

yvmunayev, LeandroTorresSicilia

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

BORDER_RADIUS_SEMI_ROUNDED,
} from '../../styles/borderRadius';

const BorderRadiusElement = styled.div`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.


export const Dropdown = attachThemeAttrs(styled.div)`
export const Dropdown = attachThemeAttrs(styled(BorderRadiusElement))`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.


const StyledDropdown = attachThemeAttrs(styled.div)`
const StyledDropdown = attachThemeAttrs(styled(BorderRadiusElement))`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

@github-actions
Copy link

github-actions bot commented Nov 27, 2022

Visit the preview URL for this PR (updated for commit 22b92c1):

https://react-rainbow--pr2552-fix-change-border-ra-l62deawh.web.app

(expires Sat, 10 Dec 2022 18:13:01 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2de6d670498a0a515484c5637b13d0215372df83

@codeclimate
Copy link

codeclimate bot commented Dec 3, 2022

Code Climate has analyzed commit 22b92c1 and detected 5 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 5

View more on Code Climate.

@LeandroTorresSicilia LeandroTorresSicilia merged commit cff8398 into master Dec 3, 2022
@LeandroTorresSicilia LeandroTorresSicilia deleted the fix-change-border-radius-in-popup-menus-of-the-inputables branch December 3, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add borderRadius prop to Modal fix: change border radius in popup menus of the inputables
2 participants