New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change border radius in popup menus of the inputables #2552
fix: change border radius in popup menus of the inputables #2552
Conversation
Bug Fixes
Chore
Features
Contributorsyvmunayev, LeandroTorresSicilia Commit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
BORDER_RADIUS_SEMI_ROUNDED, | ||
} from '../../styles/borderRadius'; | ||
|
||
const BorderRadiusElement = styled.div` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
|
||
export const Dropdown = attachThemeAttrs(styled.div)` | ||
export const Dropdown = attachThemeAttrs(styled(BorderRadiusElement))` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
|
||
const StyledDropdown = attachThemeAttrs(styled.div)` | ||
const StyledDropdown = attachThemeAttrs(styled(BorderRadiusElement))` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
Visit the preview URL for this PR (updated for commit 22b92c1): https://react-rainbow--pr2552-fix-change-border-ra-l62deawh.web.app (expires Sat, 10 Dec 2022 18:13:01 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2de6d670498a0a515484c5637b13d0215372df83 |
…es' of https://github.com/nexxtway/react-rainbow into fix-change-border-radius-in-popup-menus-of-the-inputables
Code Climate has analyzed commit 22b92c1 and detected 5 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
fix: #2540
fix: #2542
Changes proposed in this PR:
fix: change border radius in popup menus of the inputables
feat: add borderRadius prop to Modal
I have followed (at least) the PR section of the contributing guide.
@nexxtway/react-rainbow