Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: border radius in lookup component #2558

Merged
merged 14 commits into from Jan 9, 2023

Conversation

yvmunayev
Copy link
Contributor

fix: #2557

Changes proposed in this PR:

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Dec 5, 2022

Bug Fixes

  • change to chip variant (2819d26)
  • border radius in lookop component (a4bce6d)

Tests

  • fix integration test (06b1566)
  • fix clickSelectedOptionInput integration test (4009c9c)

Chore

Contributors

yvmunayev, LeandroTorresSicilia

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

…to fix-border-radius-in-lookop-component
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Visit the preview URL for this PR (updated for commit 7614bb3):

https://react-rainbow--pr2558-fix-border-radius-in-sjy3gmqj.web.app

(expires Mon, 16 Jan 2023 23:11:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2de6d670498a0a515484c5637b13d0215372df83

@@ -48,14 +56,15 @@ export default class SelectedValue extends Component {
this.inputRef.current.blur();
}

renderInput() {
render() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function render has 79 lines of code (exceeds 25 allowed). Consider refactoring.

@codeclimate
Copy link

codeclimate bot commented Jan 9, 2023

Code Climate has analyzed commit 7614bb3 and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1
Duplication 3

View more on Code Climate.

@LeandroTorresSicilia LeandroTorresSicilia merged commit fef7965 into master Jan 9, 2023
@LeandroTorresSicilia LeandroTorresSicilia deleted the fix-border-radius-in-lookop-component branch January 9, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: selected value border radius in lookup component
2 participants