feat: Implement the utility section in Library. #320
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| <RenderIf isTrue={activeTabName === 'utils'}> | ||
| <Prismic repo="react-rainbow-utility"> | ||
| <div className="react-rainbow-utils_container"> | ||
| <QueryMulti component={Util} type="page-object"> |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
| <QueryAt path="document.type" value="page-object" /> | ||
| <QueryAt path="document.tags" value={[name]} /> | ||
| </QueryMulti> | ||
| <QueryMulti component={Util} type="tutorials"> |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
| </QueryMulti> | ||
| </div> | ||
| <div className="react-rainbow-utils_container"> | ||
| <QueryMulti component={Util} type="experience-examples"> |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
Pull Request Test Coverage Report for Build 1509
💛 - Coveralls |
| import FlaskIcon from './flaskIcon'; | ||
| import GraduationCapIcon from './graduationCapIcon'; | ||
|
|
||
| export default function IntegrationCard({ results, type }) { |
There was a problem hiding this comment.
Function IntegrationCard has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
|
|
||
| export default function ExperienceExampleCard({ results }) { | ||
| return results.map(({ data, id }) => ( | ||
| <div> |
| <h1 className="react-rainbow-utils-text_header">Real experience examples</h1> | ||
| <p className="react-rainbow-utils-text-description"> | ||
| The Real experience examples will help you get | ||
| started building your app using the Button Component. |
There was a problem hiding this comment.
using the Button Component?
here you need to use:
using the ${componentName} Component ...
but here this is not correctly because you are rendering this many times as the results length
| </div> | ||
| )}> | ||
| <div className="react-rainbow-utils-item_img-container"> | ||
| <img src={data.image.url} alt="" /> |
There was a problem hiding this comment.
use in the alt attribute the example name
| import React from 'react'; | ||
| import PropTypes from 'prop-types'; | ||
| import ExperienceExampleCard from './experienceExampleCard'; | ||
| import IntergrationCard from './intergrationCard'; |
| <a href={data.url.url} className="react-rainbow-utils-link"> | ||
| <Card | ||
| className="react-rainbow-utils-item" | ||
| key={id} |
There was a problem hiding this comment.
put key in anchor element
| <QueryAt path="document.type" value="page-object" /> | ||
| <QueryAt path="document.tags" value={[name]} /> | ||
| </QueryMulti> | ||
| <QueryMulti component={Util} type="tutorials"> |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| <RenderIf isTrue={activeTabName === 'utils'}> | ||
| <Prismic repo="rainbow-doc"> | ||
| <div className="react-rainbow-utils_container"> | ||
| <QueryMulti component={Util} type="page-object"> |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| import FlaskIcon from './flaskIcon'; | ||
| import GraduationCapIcon from './graduationCapIcon'; | ||
|
|
||
| export default function PageObjectCard({ results, type }) { |
There was a problem hiding this comment.
Function PageObjectCard has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
|
Code Climate has analyzed commit 1888219 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
fixes #266