Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement the AvatarMenu component #330

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

cmcartaya
Copy link
Collaborator

fix: #309

@codeclimate
Copy link

codeclimate bot commented Oct 23, 2018

Code Climate has analyzed commit 3115e76 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2

View more on Code Climate.

/**
* A Avatar Menu offers a list of actions or functions that a user can access.
*/
export default function AvatarMenu(props) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function AvatarMenu has 34 lines of code (exceeds 25 allowed). Consider refactoring.

this.avatarButtonRef.current.blur();
}

render() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function render has 40 lines of code (exceeds 25 allowed). Consider refactoring.

Copy link
Collaborator

@reiniergs reiniergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@reiniergs reiniergs merged commit f28b3be into master Oct 23, 2018
@reiniergs reiniergs deleted the avatarMenu-implementation branch October 23, 2018 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: implement the AvatarMenu component
2 participants