test: add pagination tests #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const pageButtons = component.find('li.rainbow-pagination_button'); | ||
| expect(pageButtons.get(2).props.className).toBe('rainbow-pagination_button rainbow-pagination_button--active'); | ||
| }); | ||
| it('should set aria-current to "page" to the active anchor element', () => { |
There was a problem hiding this comment.
add test when is not active that set aria-current to undefined
| const component = mount(<PageButtons pages={1} onChange={onChangeMockFn} activePage={1} />); | ||
| const anchor = component.find('a'); | ||
| anchor.simulate('click'); | ||
| expect(onChangeMockFn).toHaveBeenCalledTimes(1); |
There was a problem hiding this comment.
check instead toHaveBeenCalledWith to test that it is called with the right arguments
| const anchor = component.find('a'); | ||
| anchor.simulate('click'); | ||
| expect(onChangeMockFn).toHaveBeenCalledTimes(1); | ||
| }); |
There was a problem hiding this comment.
add test for aria-label
| const component = mount(<Pagination pages={5} activePage={5} />); | ||
| const navButtons = component.find('NavigationButton'); | ||
| expect(navButtons.get(1).props.disabled).toBe(true); | ||
| }); |
There was a problem hiding this comment.
add test that check that aria-label is set to pagination.
also add a11y test
add test for onClick in NavigationButton (both).
LeandroTorresSicilia
approved these changes
Oct 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.