docs: change pagination examples #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/components/Pagination/readme.md
Outdated
| const firstItem = lastItem - 3; | ||
| return this.content.slice(firstItem, lastItem).map(({ title, image }) => ( | ||
| <Card className="rainbow-m-bottom_small rainbow-m-right_small" style={{ width: '32%' }}> | ||
| <div className="rainbow-flex rainbow-flex_column rainbow_vertical-stretch" style={{ height: '100%' }}> |
There was a problem hiding this comment.
no styles inline
fix all
TahimiLeonBravo
requested changes
Oct 27, 2018
| <div className="rainbow-flex rainbow-flex_column rainbow_vertical-stretch" style={{ height: '100%' }}> | ||
| <img src={image} style={{ width: '100%', flex: '1' }} /> | ||
| <span className="rainbow-font-size-text_large rainbow-color_dark-1 rainbow-p-bottom_small rainbow-p-top_small" style={{ alignSelf: 'center' }}>{title}</span> | ||
| </div> |
There was a problem hiding this comment.
use the footer for the title
src/components/Pagination/readme.md
Outdated
| const lastItem = activePage * 3; | ||
| const firstItem = lastItem - 3; | ||
| return this.content.slice(firstItem, lastItem).map(({ title, image }) => ( | ||
| <Card className="rainbow-m-bottom_small rainbow-m-right_small" style={{ width: '32%' }}> |
There was a problem hiding this comment.
use the rainbow-m-bottom_x-large instead rainbow-m-bottom_small
| {this.getContent()} | ||
| </div> | ||
| <Pagination className="rainbow-m_auto" pages={6} activePage={activePage} onChange={this.handleOnChange} /> | ||
| <Pagination className="rainbow-m_auto" pages={4} activePage={activePage} onChange={this.handleOnChange} /> | ||
| </div> |
There was a problem hiding this comment.
the arrows in the pagination componet is not centered
you are using the wrong styles in the svg. You don't need put styles to the svg, you can styles to the parent for center the svg.
Pull Request Test Coverage Report for Build 113
💛 - Coveralls |
LeandroTorresSicilia
approved these changes
Oct 28, 2018
TahimiLeonBravo
approved these changes
Oct 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #356