feat: add isLoading to the Button component #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/components/Button/index.js
Outdated
| } = this.props; | ||
|
|
||
| const isDisabled = this.isDisabled(); |
There was a problem hiding this comment.
It is fine, but here you don't need to create a method for this since it is not used in any other place.
src/components/Button/styles.scss
Outdated
| @@ -217,3 +222,39 @@ | |||
| .rainbow-button--shaded { | |||
| box-shadow: $shadow-1; | |||
| } | |||
|
|
|||
| .rainbow-button--content-hidden { | |||
There was a problem hiding this comment.
I think that .rainbow-button_content--hidden follow the class convention since content is a subcomponent not a modifier.
src/components/Button/styles.scss
Outdated
| .rainbow-button--content-hidden { | ||
| visibility: hidden; | ||
|
|
||
| .rainbow-button--spinner-visible { |
LeandroTorresSicilia
approved these changes
Oct 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #349