test: add chart tests and examples #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import resolveDatasets from '../resolve-datasets'; | ||
|
|
||
| describe('resolveDatasets function', () => { | ||
| it('should return the dataset array with the right data', () => { |
There was a problem hiding this comment.
remove this and only leave the below test.
reiniergs
reviewed
Nov 4, 2018
src/components/Dataset/readme.md
Outdated
| <Dataset title="Dataset 2" values={[66,100,30,156]} backgroundColor={'#01b6f5'} /> | ||
| <Chart labels={['A', 'B', 'C', 'D']} type="line" className="rainbow-m-right_small rainbow-m-left_x-large rainbow-m-top_x-large"> | ||
| <Dataset title="Dataset 1" values={[23,45,123,56]} backgroundColor={'#1de9b6'} borderColor={'#1de9b6'} /> | ||
| <Dataset title="Dataset 2" values={[66,100,30,156]} backgroundColor={'#01b6f5'} borderColor={'#01b6f5'} /> |
There was a problem hiding this comment.
can by backgroundColor="#01b6f5"??
Pull Request Test Coverage Report for Build 230
💛 - Coveralls |
LeandroTorresSicilia
approved these changes
Nov 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.