Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bases2fastq doesn't use generate_fastq_meta so fcid is null #56

Closed
edmundmiller opened this issue Oct 5, 2022 · 2 comments
Closed

bases2fastq doesn't use generate_fastq_meta so fcid is null #56

edmundmiller opened this issue Oct 5, 2022 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@edmundmiller
Copy link
Collaborator

Description of the bug

example output:

tree null/
null/
├── 20220601_PLT-03_BBS-0174_1.fastp.fastq.gz
├── 20220601_PLT-03_BBS-0174_1_fastqc.html
├── 20220601_PLT-03_BBS-0174_1_fastqc.zip
├── 20220601_PLT-03_BBS-0174_2.fastp.fastq.gz
├── 20220601_PLT-03_BBS-0174_2_fastqc.html
├── 20220601_PLT-03_BBS-0174_2_fastqc.zip
├── 20220601_PLT-03_BBS-0174.fastp.html
├── 20220601_PLT-03_BBS-0174.fastp.json
├── 20220601_PLT-03_BBS-0174.fastp.log
├── DefaultSample_R1.fastq.gz.md5
├── DefaultSample_R2.fastq.gz.md5
├── Unassigned_R1.fastq.gz.md5
└── Unassigned_R2.fastq.gz.md5```

### Command used and terminal output

_No response_

### Relevant files

_No response_

### System information

_No response_
@edmundmiller edmundmiller added the bug Something isn't working label Oct 5, 2022
@edmundmiller edmundmiller self-assigned this Oct 5, 2022
@edmundmiller edmundmiller added this to the v1.1.0 milestone Oct 5, 2022
@matthdsm
Copy link
Collaborator

matthdsm commented Oct 7, 2022

Shouldn't b2fq have a custom generate_fastq_meta? I think that might be valuable downstream, especially if we want to convert everything to subworkflows.

I haven't tested b2fq. Am I correct that there's no real meta / sample for the output?

@edmundmiller edmundmiller removed this from the v1.1.0 milestone Oct 13, 2022
@matthdsm
Copy link
Collaborator

fixed in #63

@edmundmiller edmundmiller added this to the v1.1.0 milestone Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants