Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Over-representation analysis in addition to GSEA #101

Closed
grst opened this issue Mar 24, 2023 · 2 comments
Closed

Over-representation analysis in addition to GSEA #101

grst opened this issue Mar 24, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@grst
Copy link
Member

grst commented Mar 24, 2023

Description of feature

As far as I can tell the differentialabundance pipeline currently performs gene set enrichment analysis using the gsea-cli. It would be great to additionally support gene set analysis using a simple over-representation test (ORA, aka Fisher's exact test) based on the differential gene expression results.

ORA is very easy to compute and to interpret and has therefore been recommended in Geistlinger et al's benchmark paper.

Another advantage of basing the results on the list of differentially expressed genes is that the GSEA cli does not seem to model covariates. By using the DE genes the results are automatically accounted for an arbitrary design specified to DESeq2.

Possible implementation

Using the clusterProfiler package, more specifically:

P.S. clusterProfiler also implements GSEA based on a ranked gene list derived from differential expression analysis. I expect this is both faster than the GSEA cli and (being based on the corresponding DE gene list) takes covariates into account.

@grst grst added the enhancement New feature or request label Mar 24, 2023
@pinin4fjords
Copy link
Member

Sure, I'm a little wary of the Fishers-based methods because of arbitrary thresholding and methodological issues, but they remain popular, so I'd support having one here. You're correct on the covariates of course- I actually really like the limma-hosted methods (romer(), piano() and so on) for that reason (though they're easier to integrate with edgeR than I suspect they would be for DESeq2). I do also have a plan to use the preranked mode for GSEA, which if based on the estimated fold changes from modelling might allow some consideration of covariates.

For consistency with how we're doing things so far in the workflow, we'd need a non-local clusterProfiler module first. If you could look at how the output of the DESeq2 module is structured that will inform on how you might structure the input channel(s).

I'm inclined to keep the GSEA implementation as-is, just because it's well established and recognised.

@pinin4fjords
Copy link
Member

@WackerO 's work on gprofiler2 addresses the request for over-representation, so closing this for now. PRs implementing other methods welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants