Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an observation_name_col parameter #66

Closed
pinin4fjords opened this issue Feb 10, 2023 · 1 comment · Fixed by #60
Closed

Add an observation_name_col parameter #66

pinin4fjords opened this issue Feb 10, 2023 · 1 comment · Fixed by #60
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@pinin4fjords
Copy link
Member

pinin4fjords commented Feb 10, 2023

Description of feature

The underlying issue @WackerO was trying to tackle in #62 is a mismatch between column headers of an expression matrix and the rows of a sample sheet. This can be more simply fixed by including the relevant data in the sample sheet (for example the bam file name output by featurecounts in the column header), and setting the appropriate observation_id_col in the workflow parameters.

The down-side of this is that all the plots etc will have the filenames, which is less than ideal.

Analagous to the existing feature_name_col, we need an observation_name_col that will allow us to use a different display name for samples than the one used in the expression matrix.

This will also require some upstream changes in shinyngs.

@pinin4fjords pinin4fjords added the enhancement New feature or request label Feb 10, 2023
@pinin4fjords pinin4fjords added this to the 1.1.0 milestone Feb 10, 2023
@pinin4fjords
Copy link
Member Author

Added to the 1.1 milestone- I think this is important

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant