Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMPcombi does not execute when only MACREL #241

Closed
jfy133 opened this issue Mar 8, 2023 · 1 comment · Fixed by #242
Closed

AMPcombi does not execute when only MACREL #241

jfy133 opened this issue Mar 8, 2023 · 1 comment · Fixed by #242
Assignees
@Darcy220606
Labels
bug Something isn't working
Milestone
1.1 - British Bea...

Comments

@jfy133
Copy link
Member

jfy133 commented Mar 8, 2023

Description of the bug

We currently use the macrel subcommand that does it's own annotations, therefore we do not run annotation in the pipeline when specifying macrel only. In this case a join of the FAA back to the FNA doesn't occur meaning AMPcombi does not recieve input.

We should switch from macrel contigs to macrel peptides

Command used and terminal output

No response

Relevant files

No response

System information

No response
@jfy133 jfy133 added the bug Something isn't working label Mar 8, 2023
@jfy133 jfy133 added this to the 1.1 - British Beans on Toast milestone Mar 8, 2023
@jfy133 jfy133 linked a pull request Mar 8, 2023 that will close this issue
Local module for AMPcombi database downloading #240
Merged
9 tasks
@jfy133 jfy133 removed a link to a pull request Mar 8, 2023
Local module for AMPcombi database downloading #240
Merged
9 tasks
@Darcy220606 Darcy220606 mentioned this issue Mar 10, 2023
Merged
9 tasks
@Darcy220606 Darcy220606 linked a pull request Mar 10, 2023 that will close this issue
fix macrel faa input #242
Merged
9 tasks
@jasmezz
Copy link
Collaborator

jasmezz commented Apr 20, 2023

Solved by #242

@jasmezz jasmezz closed this as completed Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Darcy220606 Darcy220606

Labels
bug Something isn't working
Projects
None yet
Milestone
1.1 - British Beans on Toast
Development

Successfully merging a pull request may close this issue.

fix macrel faa input Darcy220606/funcscan
3 participants
@jfy133 @jasmezz @Darcy220606