Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QC check after annotation to avoid empty annotation files being screened #246

Closed
alexhbnr opened this issue Mar 23, 2023 · 3 comments · Fixed by #297
Closed

Add QC check after annotation to avoid empty annotation files being screened #246

alexhbnr opened this issue Mar 23, 2023 · 3 comments · Fixed by #297
Assignees
Labels
enhancement Improvement for existing functionality

Comments

@alexhbnr
Copy link

Description of feature

When poor quality data are used as input into nf-core/funcscan, the initial annotation step might not return a single annotation but produce an empty FastA file. Currently, the workflow attempts to profile this empty FastA file in the subsequent workflows, leading to a failure of a task. After the whole pipeline has finished, there is an overview of the execution of the pipeline and it will list the number of failed tasks. However, from this report it is not apparent that it failed because there were no input data available from the start.

It would be great, if either
a) there is a test after the annotation step that discards such samples and doesn't attempt to profile them
or
b) provides a more informative error message that indicates that the tasks failed due to insufficient input data.

@alexhbnr alexhbnr added the enhancement Improvement for existing functionality label Mar 23, 2023
@jfy133
Copy link
Member

jfy133 commented Mar 23, 2023

@alexhbnr do you have an example of an empty FASTA file? Or is it literally just equivalent to touch <filename>.fasta?

@jfy133 jfy133 self-assigned this Mar 23, 2023
@alexhbnr
Copy link
Author

The latter. It's completely empty.

@jfy133
Copy link
Member

jfy133 commented Mar 23, 2023

Maybe we can check file size with: https://www.nextflow.io/docs/latest/script.html#check-file-attributes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement for existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants