Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate pbbam/pbmerge (maybe new module: pbtk/pbmerge) #5601

Open
3 of 4 tasks
famosab opened this issue May 14, 2024 · 2 comments
Open
3 of 4 tasks

deprecate pbbam/pbmerge (maybe new module: pbtk/pbmerge) #5601

famosab opened this issue May 14, 2024 · 2 comments
Labels
new module Adding a new module

Comments

@famosab
Copy link
Contributor

famosab commented May 14, 2024

Is there an existing module for this?

  • I have searched for the existing module

Is there an open PR for this?

  • I have searched for existing PRs

Is there an open issue for this?

  • I have searched for existing issues

Are you going to work on this?

  • If I'm planning to work on this module, I added myself to the Assignees to facilitate tracking who is working on the module

Additional info

This relates to #4753:

It seems to me that pbbam was archived and the individual tools were transferred to pbtk. Tackle the proper update on a separate branch with a separate PR.

After this new module is created, pbbam/pbmerge needs to be removed.

@sguizard
Copy link
Contributor

pbmerged was used in the first version of the isoseq pipeline. After a modification of the analysis strategy, pbmerge has been removed and not used by any pipeline.
I've kept maintained it along with the other Pacbio modules to keep available in the hypothesis where would like to use it.
Unless someone planned to use it in a new pipeline, I don't think it's necessary to keep a module for pbmerge.

@SPPearce
Copy link
Contributor

Note that pbmerge should be deprecated following the guidelines in: https://nf-co.re/docs/contributing/modules#deprecating-a-module

@famosab famosab changed the title new module: pbtk/pbmerge deprecate pbbam/pbmerge (maybe new module: pbtk/pbmerge) May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new module Adding a new module
Projects
Status: No status
Development

No branches or pull requests

3 participants