Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple nextflow versions in CI #88

Closed
edmundmiller opened this issue Dec 1, 2020 · 5 comments · Fixed by #90
Closed

Support multiple nextflow versions in CI #88

edmundmiller opened this issue Dec 1, 2020 · 5 comments · Fixed by #90
Assignees
Labels
enhancement New feature or request tests Related to automated tests

Comments

@edmundmiller
Copy link
Contributor

Should we support multiple nextflow versions in the CI? If so which ones. See 8cd635f

@edmundmiller edmundmiller added enhancement New feature or request tests Related to automated tests labels Dec 1, 2020
@drpatelh
Copy link
Member

drpatelh commented Dec 1, 2020

Good question 👍 Maybe we run against the first stable DSL2 release i.e. 20.07.1 as well as the latest? The pipeline CI tests do something similar but in this instance it ensures that the modules are working across the full spectrum of DSL2 releases. If we encounter breaking changes we can bump the minimum version used for the tests.

@drpatelh
Copy link
Member

drpatelh commented Dec 1, 2020

Note the matrix tests will look something like this

@edmundmiller
Copy link
Contributor Author

edmundmiller commented Dec 2, 2020

Gotcha! Thanks I couldn't find the right value for "latest"! I'll make another PR once #85 is merged.

@drpatelh
Copy link
Member

As a result of the changes introduced in #109 we now have the ability to directly download Singularity containers, however, this functionality was added in an edge release i.e. 20.11.0-edge. This means I had to change the version of Nextflow we use for the module CI as shown in this commit. After the next stable Nextflow release we should revert the CI to using nxf_version: [<STABLE_RELEASE>, ""] again. Note the "" in that list will pull the latest stable release which at this point doesn't contain the functionality we need which is why I removed it in that commit.

@drpatelh drpatelh reopened this Dec 14, 2020
@drpatelh
Copy link
Member

drpatelh commented Mar 26, 2021

Hmmmm...after the recent (and superdooper) surge in modules and the failure of all of the current tests to be triggered with one NF version (due to Github Actions matrix limit of 256), I think testing multiple NF versions is overkill until something changes. At which point feel free to re-open this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests Related to automated tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants