Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicycler should allow also long read and hybrid assembly #890

Closed
d4straub opened this issue Oct 25, 2021 · 0 comments · Fixed by #1041
Closed

Unicycler should allow also long read and hybrid assembly #890

d4straub opened this issue Oct 25, 2021 · 0 comments · Fixed by #1041
Labels
enhancement New feature or request

Comments

@d4straub
Copy link
Contributor

d4straub commented Oct 25, 2021

Is your feature request related to a problem? Please describe

The Unicycler module only allows short read assembly but not long read or hybrid assembly.

Describe the solution you'd like

A module that does it all, like in nf-core/bacass.

This is also mentioned in nf-core/bacass#61

Describe the solution you'd like

Instead of

    input:
    tuple val(meta), path(reads)

and
def input_reads = meta.single_end ? "-s $reads" : "-1 ${reads[0]} -2 ${reads[1]}"

one could do

    input:
    tuple val(meta), path(shortreads), path(longreads)

and

    if(shortreads){
        def short_reads = meta.single_end ? "-s $shortreads" : "-1 ${shortreads[0]} -2 ${shortreads[1]}"
    } else { def short_reads =  "" }
    def long_reads = longreads ? "-l $longreads" : ""
    def input_reads = "$short_reads $long_reads"

where [] would be given into the input channel when no respective reads exist.

Describe alternatives you've considered

Alternatively, this could be as well solved in 3 different modules, sich as Unicycler_short, Unicycler_long & Unicycler_hybrid. I am not sure whats the better way.

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Hackathon-October-2021
[Main] MAG/Bacass
Development

Successfully merging a pull request may close this issue.

1 participant