Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline in WGS mode appears to require target_bed #375

Closed
lfearnley opened this issue Jul 13, 2023 · 8 comments · Fixed by #395
Closed

Pipeline in WGS mode appears to require target_bed #375

lfearnley opened this issue Jul 13, 2023 · 8 comments · Fixed by #395
Assignees
Labels
bug Something isn't working
Milestone

Comments

@lfearnley
Copy link

Description of the bug

When I run the pipeline in WGS mode target_bed must be supplied, or it feeds a null value to TABIX_PBT, causing the pipeline to crash.

The documentation suggests that target_bed is optional.

Command used and terminal output

No response

Relevant files

No response

System information

nf-core/raredisease 1.0 (current git master)

@lfearnley lfearnley added the bug Something isn't working label Jul 13, 2023
@ramprasadn
Copy link
Collaborator

Hi @lfearnley! Could you share your nextflow.log from a failed run?

@lfearnley
Copy link
Author

Hi @ramprasadn - will do once it's available; I've had another run failure on a different issue.

Speaking of which - I'm running raredisease on GRCh38 WGS using the install instructions and encountering a reasonably large number of issues; how did you want me to handle these? Github issues with 1 per problem/query, or email?

@ramprasadn
Copy link
Collaborator

Sounds good!

That's concerning..
I think it'd be better if you open a Github issue for each problem/query, as it will allow other users and devs to pitch in with their experiences. 😄

@lfearnley
Copy link
Author

Sure thing! Not too concerning - I think most of what I'm hitting is related to documentation/defaults that aren't getting set for some reason. I'll start with two I can think of off the top of my head.

On this issue though, a related question - running the pipeline in WGS mode seems to still result in PICARD_COLLECTHSMETRICS running. I'm not sure that makes sense?

@fa2k
Copy link
Contributor

fa2k commented Jul 20, 2023

I also had this issue with intervals file and ended up adding a bed file for the whole genome. I agree that the best would be to disable CollectHSMetrics when using WGS, as it's not applicable. @lfearnley I have many of the same issues and you can see some notes (quite terse, sorry) in my repo README https://github.com/fa2k/raredisease-configs/tree/main , a bit down under Reference Data. I've also had great benefit from Clinical Genomics's repo https://github.com/Clinical-Genomics/reference-files/ and the test datasets. I think it's great that you're making issues in github instead of just working around it like I did, though.

@lfearnley
Copy link
Author

@fa2k Thanks so much for that!

The only thing I'd check/flag in your notes (which are immensely helpful - there's one or two steps I've yet to debug that they clear up for me) is that the gnomAD SV 2.1 listed is possibly aligned against hg19 and the other files are aligned against GRCh38. I've been using the gnomAD 2.1.1 GRCh38 liftover from dbVar which is linked at gnomAD's download page if that helps for an update.

@fa2k
Copy link
Contributor

fa2k commented Jul 21, 2023

Thanks @lfearnley for the correction on gnomAD SV, this will save me a lot of headaches:) (I'll also try to adapt to the new changes in the dev branch, there are some new arguments.)

@ramprasadn ramprasadn added this to the Release 1.2.0 milestone Jul 21, 2023
@ramprasadn ramprasadn linked a pull request Aug 1, 2023 that will close this issue
11 tasks
@ramprasadn ramprasadn self-assigned this Aug 2, 2023
@ramprasadn
Copy link
Collaborator

Fixed in #395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants