Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename RSEM_PREPAREREFERENCE_TRANSCRIPTS process #755

Closed
drpatelh opened this issue Jan 27, 2022 · 1 comment
Closed

Rename RSEM_PREPAREREFERENCE_TRANSCRIPTS process #755

drpatelh opened this issue Jan 27, 2022 · 1 comment
Milestone

Comments

@drpatelh
Copy link
Member

drpatelh commented Jan 27, 2022

Description of feature

A number of users have been confused by the fact that it appears like RSEM is running as a result of this process RSEM_PREPAREREFERENCE_TRANSCRIPTS even though they aren't using the --aligner star_rsem option.

That process is actually just leveraging the rsem-prepare-reference command to generate the transcriptome from the GTF and the genome fasta which is why I called it RSEM_PREPAREREFERENCE_TRANSCRIPTS, as shown in the code below:

ch_transcript_fasta = RSEM_PREPAREREFERENCE_TRANSCRIPTS ( ch_fasta, ch_filter_gtf ).transcript_fasta

The reason I chose rsem-prepare-reference is that we know that the transcriptome will be compatible with Salmon too and if there are any issues with the conversion then RSEM tends to fail at this step to allow the user to "fix" their annotations.

We should probably rename this process to MAKE_TRANSCRIPTOME in the next release to avoid this common misconception.

@drpatelh drpatelh added this to the 3.6 milestone Feb 7, 2022
@drpatelh
Copy link
Member Author

Will be fixed in #763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant