Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting does not recognize README Nextflow minimum version mention in Quick Start #1260

Closed
chris-cheshire opened this issue Aug 9, 2021 · 1 comment
Closed

Linting does not recognize README Nextflow minimum version mention in Quick Start #1260

chris-cheshire opened this issue Aug 9, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@chris-cheshire
Copy link
Contributor

When running nf-core lint with a readme file that has the following in it:

## Quick Start

1. Install [`Nextflow`](https://www.nextflow.io/docs/latest/getstarted.html#installation) (`>=21.04.0`)

A warning is triggered:

readme: README did not have a Nextflow minimum version mentioned in Quick Start section.

This warning should not be triggering as the minimum nextflow version is in the readme file.

Link to code location

tools/nf_core/lint/readme.py

Lines 65 to 66 in 0129101

# Looking for: "1. Install [`Nextflow`](https://nf-co.re/usage/installation) (`>=21.04.0`)"
nf_version_re = r"1\.\s*Install\s*\[`Nextflow`\]\(https://nf-co.re/usage/installation\)\s*\(`>=(\d*\.\d*\.\d*)`\)"

@chris-cheshire chris-cheshire added the bug Something isn't working label Aug 9, 2021
@ErikDanielsson ErikDanielsson mentioned this issue Aug 9, 2021
Merged
4 tasks
@ErikDanielsson
Copy link
Contributor

Closing due to the merge of #1261.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chris-cheshire @ErikDanielsson