Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ROP to RenderMan 25 #2

Merged
merged 8 commits into from
Oct 2, 2023
Merged

Update ROP to RenderMan 25 #2

merged 8 commits into from
Oct 2, 2023

Conversation

MaximumFX
Copy link
Contributor

  • Partial update to RenderMan 25 due to time constraints.
  • Added more artist friendly method for setting up AOVs.
  • Updated Deadline submission.

@MaximumFX MaximumFX added the enhancement New feature or request label Sep 29, 2023
@MaximumFX MaximumFX self-assigned this Sep 29, 2023
@MaximumFX MaximumFX linked an issue Sep 29, 2023 that may be closed by this pull request
Update to RenderMan 25 #1
Closed
mervinvb
mervinvb reviewed Sep 29, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
mervinvb
mervinvb reviewed Sep 29, 2023
View reviewed changes
app.py Outdated Show resolved Hide resolved
mervinvb
mervinvb requested changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@mervinvb mervinvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heyoo, added some comments here and there, just formatting issues though, code looks good to me! Do you have time to fix them? If not we might just have to merge because we need this thing to work pretty soon lol

@MaximumFX
Copy link
Contributor Author

Made changes according to Mervin's comments.

gillesvink
gillesvink requested changes Sep 30, 2023
View reviewed changes
Copy link
Contributor

@gillesvink gillesvink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some comments while reading, I know time is limited in the fourth year, but these comments might give some insights. Anyway really cool! Nice improvements :)

app.py Outdated Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
app.py Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
app.py Show resolved Hide resolved
python/tk_houdini_renderman/handler.py Outdated Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
python/tk_houdini_renderman/farm_dialog.py Outdated Show resolved Hide resolved
python/tk_houdini_renderman/handler.py Outdated Show resolved Hide resolved
@MaximumFX MaximumFX merged commit 5e3c7fa into main Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gillesvink gillesvink gillesvink requested changes

@mervinvb mervinvb mervinvb requested changes

Assignees

@MaximumFX MaximumFX

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to RenderMan 25
3 participants
@MaximumFX @gillesvink @mervinvb