Add --ci-check, verbosity control (-v/-q) and --config option #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalito
changed the title
Update data files for testing to conform to checks. Add tests for ci-check and use new config update method.
dalito
changed the title
This should close the handlers (and files) before exit.
With this all CL scripts can log with their name and we avoid a conflict in hierarchy for convert which is used once as module and once as CLI script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new option
--ci-checkto the voc4cat command line interface to run the checks made for CI/gh-actions (in #131). Some improvements were made along the way:idrange.toml).config.py(again) to make updating the config easier and to ensure consistent state (important for testing).merge_vocabto be a argparse-based CLI script with logging.Still to do:
--ci-checkoption works fine in CI / gh-actions of voc4cat-template.Closes #133