Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Assay identifier is not added to isa.investigation file #234

Closed
andreaschrader opened this issue Dec 14, 2023 · 1 comment
Closed

Comments

@andreaschrader
Copy link
Member

Describe the bug
When registering an assay, there is no assay identifier row in all three isa.xlsx files.

To Reproduce
Initiate an ARC, add a study with an assay (arc a add -s MyStudy -a MyAssay)

Expected behavior
A row with the assay identifier similar to study identifier.

OS and framework information (please complete the following information):
macOS
arc commander v0.5.0 same for v1.0.0 (preview2)

@HLWeil
Copy link
Member

HLWeil commented Dec 22, 2023

Hey @andreaschrader,

this is because this field does neither exist in ISA Tab nor ISA Json (which is a shame). Having the Identifier as a argument is just for user convenience.

Feel free to add your perspective in nfdi4plants/ARC-specification#74.

@HLWeil HLWeil closed this as completed Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants