Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#16 New IO parser(s) #17

Merged
merged 3 commits into from
Jul 17, 2023
Merged

#16 New IO parser(s) #17

merged 3 commits into from
Jul 17, 2023

Conversation

omaus
Copy link
Collaborator

@omaus omaus commented Jul 16, 2023

Since new IO parsers are needed for arc-validate, this PR

  • split parsing functions for rows, columns, and table columns into
    • aggregated and flat, where aggregated produces an ICvBase list (containing CvParams and CvContainers), and flat produces an IParam list (containing only CvParams)
  • Closes [Feature] New parser for ArcGraphModel.IO #16

@omaus omaus requested a review from HLWeil July 16, 2023 22:18
@HLWeil
Copy link
Member

HLWeil commented Jul 17, 2023

The changes seem fine for getting just a CvParam list. But don't forget to extend the list of KeyMappers if you want to transform all fields to CvParams. I didn't finish it up completely.
https://github.com/nfdi4plants/ArcGraphModel/blob/74c57e61aa5cd798cf0702f9daab053b14af32b2/src/ArcGraphModel.IO/ISA/KeyParser.fs#L38

@omaus omaus merged commit 6ccf979 into main Jul 17, 2023
2 checks passed
@omaus omaus deleted the feature-newIOParser-#16 branch July 17, 2023 08:23
@omaus omaus mentioned this pull request Jul 17, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HLWeil HLWeil Awaiting requested review from HLWeil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] New parser for ArcGraphModel.IO
2 participants
@omaus @HLWeil