Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand metadata tokenisation #57

Merged
merged 5 commits into from Apr 19, 2024

Conversation

LibraChris
Copy link
Contributor

Enhance metadata tokenization by ensuring that all references to YAML files in each metadata file are fully processed and incorporated and in accordance to ARC-specification 2.0.0 and isa-light.

Update ReferenceObjects to utilise Assay Person instead of the old Assay Performer
- Change ARCMock functions
- Fix Tests using ARCMock
Copy link
Member

@kMutagene kMutagene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for our current purposes, we have to keep in mind that ARCMock eventually has to be expanded even more (e.g. multiple STUDY sections, custom row order inside the sections (does the arc spec 2.0 allow this?)).

@kMutagene kMutagene merged commit 56ef698 into nfdi4plants:main Apr 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants