-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Json compression #308
Json compression #308
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, ut pls open an issue requesti g Thoth.Json update to check if performance in js is still lacking
@@ -48,9 +51,6 @@ | |||
<NpmPackage Name="jsonschema" Version="gte 1.1.0 lt 2.0.0" ResolutionStrategy="Max" /> | |||
</NpmDependencies> | |||
</PropertyGroup> | |||
<ItemGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleting this IS WORST CASE! THIS WILL BREAK ALL JS TOOLS AGAIN 😨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Why does vs do this to us though? 😢
Added compressed json encoders to reduce size of output json. These make use of Cell-, OntologyAnnotation- and Stringtables to deduplicate information.
In DotNet it's not only much smaller, but also much faster. Unfortunately, this is not the case for JS. Therefore the performance test is pending in Fable.