Json compression #308
Merged
Json compression #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freymaurer
approved these changes
Feb 14, 2024
| @@ -48,9 +51,6 @@ | |||
| <NpmPackage Name="jsonschema" Version="gte 1.1.0 lt 2.0.0" ResolutionStrategy="Max" /> | |||
| </NpmDependencies> | |||
| </PropertyGroup> | |||
| <ItemGroup> | |||
There was a problem hiding this comment.
Deleting this IS WORST CASE! THIS WILL BREAK ALL JS TOOLS AGAIN 😨
There was a problem hiding this comment.
Good catch. Why does vs do this to us though? 😢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added compressed json encoders to reduce size of output json. These make use of Cell-, OntologyAnnotation- and Stringtables to deduplicate information.
In DotNet it's not only much smaller, but also much faster. Unfortunately, this is not the case for JS. Therefore the performance test is pending in Fable.