Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add-exception-option #26

Closed
wants to merge 1 commit into from
Closed

add-exception-option #26

wants to merge 1 commit into from

Conversation

masarakki
Copy link

@masarakki masarakki commented Dec 11, 2018

it makes easy to give up and continue

Naming of exception is a semi-standard name after ruby-2.6.0
https://bugs.ruby-lang.org/issues/12732
https://bugs.ruby-lang.org/issues/14386

@nfedyashev
Copy link
Owner

Hi @masarakki !

Thanks for your pull request!
I've reviewed it and unfortunately decided not to accept it at this moment. Here's why:

  • although I understand it could be useful for some users I suspect that percent of such users is quite low.
  • it adds additional cognitive complexity on user while he reads documentation and current configuration option is already quite complicated.
  • those users who actually need this functionality can just wrap the whole retryable block in its own begin/rescue block. I believe that it would be more explicit and transparent solution for average user then noticing :exception => false config option.
  • I believe that exception: false config option is not intuitively obvious option for an average retryable user and I would like to keep the docs and configuration as simple as possible.

On the other hand I might be getting back to this pull request later as ruby-2.6 gets more wide spread and more users will become familiar with this exception: false convention/standard.

@nfedyashev nfedyashev closed this Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants