feat: avoid copying in Band
#1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Band` is implemented by using an array internally. Previously, when expanding or progressing the `Band` the items inside it were shifted by one. This was done to always keep the array filled from the start (from index 0). This commit changes the implementation of the `Band`, so that the elements can also start from anywhere in the array and wrap around it. This means that the head of array can be at the middle for example, and the last element in the `Band` is the one before the head in the array. This avoids unnecessary copying, and works with cheap index operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bandis implemented by using an array internally. Previously, when expanding or progressing theBandthe items inside it were shifted by one. This was done to always keep the array filled from the start (from index 0). This commit changes the implementation of theBand, so that the elements can also start from anywhere in the array and wrap around it. This means that the head of array can be at the middle for example, and the last element in theBandis the one before the head in the array. This avoids unnecessary copying, and works with cheap index operations.