adding static constant

nfl · Nov 30, 2016 · ffa7c40 · ffa7c40
1 parent 7392962
commit ffa7c40
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/main/java/com/nfl/glitr/annotation/GlitrArgument.java b/src/main/java/com/nfl/glitr/annotation/GlitrArgument.java
@@ -19,6 +19,8 @@
     String name();
     Class type();
     boolean nullable() default true;
-    String defaultValue() default "No Default Value";
     String description() default "No Description";
+
+    String NO_DEFAULT_VALUE = "No Default Value";
+    String defaultValue() default NO_DEFAULT_VALUE;
 }
diff --git a/src/main/java/com/nfl/glitr/registry/TypeRegistry.java b/src/main/java/com/nfl/glitr/registry/TypeRegistry.java
@@ -241,7 +241,7 @@ private GraphQLArgument createRelayInputArgument(Class methodDeclaringClass, Met
 
         // Default values need to match type so we replace our default String with null
         Object defaultValue = null;
-        if (!arg.defaultValue().equalsIgnoreCase("No Default Value")) {
+        if (!arg.defaultValue().equalsIgnoreCase(GlitrArgument.NO_DEFAULT_VALUE)) {
             defaultValue = arg.defaultValue();
         }