Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createTestManager is not a function #42

Closed
manelmadeira opened this issue Aug 25, 2017 · 2 comments
Closed

createTestManager is not a function #42

manelmadeira opened this issue Aug 25, 2017 · 2 comments

Comments

@manelmadeira
Copy link

When using the version 0.2.4, we were using createTestManager to mock GPT on our mocha tests (as documented here, but when updating to 0.2.5 we start getting the GPT.createTestManager is not a function..

Can you please update the docs?

Thanks.

@patrick-mcdougle
Copy link

I think it might just be testManager(). See https://github.com/nfl/react-gpt/blob/master/src/Bling.js#L360

@potench
Copy link
Contributor

potench commented Aug 29, 2017

I might need to look into this more (and update the docs), but in case it helps there's a createManagerTest util class
https://github.com/nfl/react-gpt/blob/f73958e7e3c88931b4e14c4e6a8ded80d2fba31f/src/utils/createManagerTest.js

And here's an example using it

Bling.testManager = createManagerTest();

jamsea pushed a commit that referenced this issue Sep 18, 2017
Export AdManager so users can create a test ad manager

Fixes #42
jamsea added a commit that referenced this issue Sep 19, 2017
Export AdManager so users can create a test ad manager
Fix peerDependencies spelling

Fixes #42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants