Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI build: update test matrix & use yarn for CI builds #397

Merged
merged 3 commits into from Nov 4, 2018

Conversation

realityking
Copy link
Contributor

This is necessary because npm 6 requires Node.js 6.

@codecov
Copy link

codecov bot commented Nov 2, 2018

Codecov Report

Merging #397 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #397   +/-   ##
======================================
  Coverage    97.6%   97.6%           
======================================
  Files           3       3           
  Lines         292     292           
======================================
  Hits          285     285           
  Misses          7       7
Impacted Files Coverage Δ
src/Helmet.js 100% <0%> (ø) ⬆️
src/HelmetUtils.js 96.87% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0716bff...9f69223. Read the comment docs.

@tmbtech
Copy link
Contributor

tmbtech commented Nov 3, 2018

@cwelch5 OK if I merge this in?

@tmbtech tmbtech merged commit a15deac into nfl:master Nov 4, 2018
@realityking realityking deleted the fix-build branch November 4, 2018 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants