Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Travis CI being unable to start GUI tests #473

Merged
merged 4 commits into from Dec 6, 2019

Conversation

KraigWalker
Copy link
Contributor

@KraigWalker KraigWalker commented Sep 15, 2019

Travis CI updated their Ubuntu environment from Trusty to 'Xenial.'

This brings about a few breaking changes to existing configs with regards to starting xvfb and retrieving google chrome from apt.

Travis CI updated their Xenial build environment, which introduced a new way to start up XVFB for front-end builds. This broke existing builds that used the approach based on their documentation.
@CLAassistant
Copy link

CLAassistant commented Sep 15, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Sep 15, 2019

Codecov Report

Merging #473 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #473   +/-   ##
======================================
  Coverage    97.6%   97.6%           
======================================
  Files           3       3           
  Lines         292     292           
======================================
  Hits          285     285           
  Misses          7       7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 420810c...5b3c1c5. Read the comment docs.

@KraigWalker KraigWalker changed the title Fix: Update travis.yml failing to start xvfb Fix: Travis CI being unable to start GUI tests Sep 15, 2019
@verheyenkoen
Copy link

Can this be merged so #472 can be released?

@gsinovsky
Copy link

@cwelch5 please check this out, would really help to have this merged so #472 can be released

@sneridagh sneridagh mentioned this pull request Nov 23, 2019
@cwelch5 cwelch5 merged commit 8176b17 into nfl:master Dec 6, 2019
sms1989 added a commit to fudevgroup/react-helmet that referenced this pull request Dec 27, 2019
Fix: Travis CI being unable to start GUI tests (nfl#473)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants