Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(package): Fix react dependency #18

Merged
merged 1 commit into from
Apr 15, 2016
Merged

fix(package): Fix react dependency #18

merged 1 commit into from
Apr 15, 2016

Conversation

taak77
Copy link
Contributor

@taak77 taak77 commented Apr 14, 2016

No description provided.

@CLAassistant
Copy link

CLA assistant check
All committers have accepted the CLA.

@codecov-io
Copy link

Current coverage is 99.47%

Merging #18 into master will increase coverage by +0.06% as of c23da84

@@            master     #18   diff @@
======================================
  Files           14      15     +1
  Stmts          343     378    +35
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit            341     376    +35
  Partial          0       0       
  Missed           2       2

Review entire Coverage Diff as of c23da84

Powered by Codecov. Updated on successful CI builds.

@taak77 taak77 force-pushed the feature/deps-fix branch 3 times, most recently from be438cc to b827ab3 Compare April 15, 2016 00:29
@beningo
Copy link
Member

beningo commented Apr 15, 2016

👍

@taak77 taak77 merged commit aee0c8d into master Apr 15, 2016
doctyper
doctyper reviewed Apr 15, 2016
View reviewed changes
package.json
@@ -37,13 +37,15 @@
"fbjs": "^0.7.2",
"hoist-non-react-statics": "^1.0.5",
"querystring": "^0.2.0",
"react": "^0.14.8",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you allow React 15.x?

@taak77
Copy link
Contributor Author

taak77 commented Apr 15, 2016

@doctyper, build failed with react v15 during npm install on Travis, which i couldn't reproduce locally with the same node version(0.12.13). I need to troubleshoot it separately.

@taak77 taak77 deleted the feature/deps-fix branch April 19, 2016 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@taak77 @CLAassistant @codecov-io @beningo @doctyper