Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner Yardline Strings #459

Merged
merged 3 commits into from Feb 29, 2024
Merged

Cleaner Yardline Strings #459

merged 3 commits into from Feb 29, 2024

Conversation

mrcaseb
Copy link
Member

@mrcaseb mrcaseb commented Feb 28, 2024

Copy link

github-actions bot commented Feb 28, 2024

because we fix an empty string in the expectation
@mrcaseb mrcaseb enabled auto-merge (squash) February 28, 2024 16:07
@mrcaseb
Copy link
Member Author

mrcaseb commented Feb 28, 2024

Now fixes nflverse/nflverse-pbp#39 as well

@mrcaseb mrcaseb linked an issue Feb 28, 2024 that may be closed by this pull request
Copy link
Member

@guga31bb guga31bb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stringr go brr

@mrcaseb mrcaseb merged commit 72f8961 into master Feb 29, 2024
7 checks passed
@mrcaseb mrcaseb deleted the fix-yrdln branch February 29, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues in kickoff descriptions drive_start_yard_line str formatting
2 participants