no kick off if previous play is weather delay #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is this logic where we set kickoff_attempt to 1 mostly for plays with penalties.
The logic uses previous play data and skips the kickoff_attempt in various situations. The logic includes that we skip a kickott_attempt if the play description of the previous play says "The game has resumed" after it has been suspended for whatever reason.
However, in 2023_13_ARI_PIT the games has been suspended twice and after the second one there ways no "The game has resumed" which made the logic set kickoff_attempt == 1 and ultimately resulted in wrong
fixed_drivenumbers (#447).This PR explicitly avoids kickoff_attempt if the previous play description says "game has been suspended". This fixes #447 but it might fail in the future if the "The game has resumed" play is missing and the play description varies for some reason.