Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data dictionary should better explain the difference between fantasy_player_id and fantasy_id #205

Open
tanho63 opened this issue Sep 2, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@tanho63
Copy link
Member

tanho63 commented Sep 2, 2023

We have two sets of similar-looking player IDs generated via different methods, which causes some confusion e.g. fantasy_player_id vs fantasy_id.

image

It would be good if the data dictionary did a better job explaining where the IDs come from (nfl json source vs parsing play descriptions) and what the differences are (including/excluding non-plays e.g. penalties or whatever else)

Original discord convo: https://discord.com/channels/789805604076126219/789817459212812289/1147612381883666512

@tanho63 tanho63 added documentation Improvements or additions to documentation good first issue Good for newcomers labels Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant