Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixed] Local setup issue #14

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Conversation

sree-hari-s
Copy link
Contributor

#6
The issue was because the migrations file was ignored by the .gitignore file

I have updated the .gitignore file and also added the migrations files

@nfoert
Copy link
Owner

nfoert commented Oct 3, 2023

Hi there, thanks for the PR. If you check the .gitignore, I'm already ignoring the migration files, so this change is not necessary.

Check this commit

@sree-hari-s
Copy link
Contributor Author

Hi there, thanks for the PR. If you check the .gitignore, I'm already ignoring the migration files, so this change is not necessary.

Check this commit

Hey I am actually mentioning to not ignore the migration files. because that was what led to the issues for local setup.

Check this link

@nfoert
Copy link
Owner

nfoert commented Oct 3, 2023

Hi there, thanks for the PR. If you check the .gitignore, I'm already ignoring the migration files, so this change is not necessary.
Check this commit

Hey I am actually mentioning to not ignore the migration files. because that was what led to the issues for local setup.

Check this link

Ok, I understand what you mean now, and I see the benefits.
Some people were having trouble with the migrations and a fix was to remove them, I think there may be a larger problem going on instead. I'll do a few tests and merge this in a bit.

I don't think all of these are necessary - if needed we can add more as the project matures, for now I'd like to keep things more simpler and less bloated.
Some are definitely important however, so I've added some new ones from the file you provided.
@nfoert
Copy link
Owner

nfoert commented Oct 3, 2023

Well, it looks like everything is working as expected. If anyone else is having trouble when setting up their server please comment here, there may still be an issue that I'm just not encountering.

Thanks for working on this @sree-hari-s!

@nfoert nfoert merged commit 18a4a89 into nfoert:main Oct 3, 2023
@nfoert
Copy link
Owner

nfoert commented Oct 3, 2023

I did end up encountering an error, but I do have a fix for it.
My error seemed to be a conflict between the migrations and the database:

django.db.utils.OperationalError: duplicate column name: current_conversation_id

I was able to fix it by running this command:

python manage.py migrate --fake

This seems to fake the migration system into thinking that all of the necessary migrations have been applied, and therefore causes the database and the migrations to be up to date. (Correct me if I am wrong :D)
Thanks to this answer for helping me out.

@sree-hari-s sree-hari-s deleted the local-setup-issue branch October 5, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants