Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated notification.js file with hide-notification #5

Merged
merged 2 commits into from
Oct 1, 2023

Conversation

charann29
Copy link
Contributor

@charann29 charann29 commented Oct 1, 2023

@nfoert
PR Description:

Changes Made:
In this PR, we've made a modification to the hide_notification function in the notification.js file. The change ensures that the notification is not hidden if notifications_muted is set to true. This adjustment is intended to align the behavior of the notification system with the requirement that when notifications are muted, the notification should not be hidden.

Reason for the Change:
Previously, the hide_notification function would always hide the notification after a certain period, regardless of whether notifications were muted or not. This behavior needed to be updated to accommodate the case where notifications are muted and should remain visible.

Impact of the Change:

  • When notifications_muted is true, the notification will not be hidden.
  • When notifications_muted is false, the notification will be hidden after the specified duration (5 seconds in this case) as before.

This change ensures that the notification system behaves as expected when notifications are muted.

@charann29
Copy link
Contributor Author

@nfoert , I kindly request your review of this change, and I would appreciate it if you could provide feedback on whether any additional modifications are required. Thank you!

@nfoert
Copy link
Owner

nfoert commented Oct 1, 2023

Thank you, I appreciate your style changes. (Fixing my missing semicolons)
I'm going to give it a test to ensure everything is correct, then I'll merge your changes

This line was preventing the code you supplied from working correctly, and fixed a different issue.
@nfoert
Copy link
Owner

nfoert commented Oct 1, 2023

I've made a change that prevented your code from working correctly, this also solved another issue I was having. Thanks for your work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants