updated notification.js file with hide-notification #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nfoert
PR Description:
Changes Made:
In this PR, we've made a modification to the
hide_notification
function in thenotification.js
file. The change ensures that the notification is not hidden ifnotifications_muted
is set to true. This adjustment is intended to align the behavior of the notification system with the requirement that when notifications are muted, the notification should not be hidden.Reason for the Change:
Previously, the
hide_notification
function would always hide the notification after a certain period, regardless of whether notifications were muted or not. This behavior needed to be updated to accommodate the case where notifications are muted and should remain visible.Impact of the Change:
notifications_muted
is true, the notification will not be hidden.notifications_muted
is false, the notification will be hidden after the specified duration (5 seconds in this case) as before.This change ensures that the notification system behaves as expected when notifications are muted.