Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect message - logic bug; plus 3.2.0 preparations #10

Closed
8 tasks done
nfreear opened this issue Feb 24, 2018 · 0 comments
Closed
8 tasks done

Incorrect message - logic bug; plus 3.2.0 preparations #10

nfreear opened this issue Feb 24, 2018 · 0 comments

Comments

@nfreear
Copy link
Owner

nfreear commented Feb 24, 2018 •
edited
Loading

... The screenshot, captured on 23 February 2018, shows the message that should be shown after the 2018 day (Thursday 17 May) — "Put next year's ..." — incorrect !!

gaad-widget--logic-bug--24-feb-2018

  • — Incorrect message - logic bug (see screenshot);
  • — Display language-specific GAAD string, not English - bug or enhancement;
  • — Re-factor language/locale/ translation/ i18n code;
  • — Cast strings to integers in JSON - parseInt( );
  • — Chinese, Simplified translation;
  • — Spanish translation, maybe ?!
  • — CHANGELOG;
  • — ... Release version 3.2.0

...?

[iet:8994834]
nfreear added a commit that referenced this issue Feb 25, 2018
@nfreear
Bug #10, cast numbers in JSON to integers parseInt() [iet:8994834]
f4c22ed 
* Plus, add `?gaadwidget=force` and `?lang=zh-cn` parameters/links to test HTML
nfreear added a commit that referenced this issue Feb 25, 2018
@nfreear
Bug #10, use language translation of "GAAD" [iet:8994834]
84aa19e 
* ... And, add English string as title attribute for link
nfreear added a commit that referenced this issue Feb 25, 2018
@nfreear
Bug #10, fix incorrect message/ logic bug [iet:8994834]
fcca26f 
* Fix - ensure a Javascript Date OR timestamp is used both sides of `-` (minus) calculation
nfreear added a commit that referenced this issue Feb 25, 2018
@nfreear
Bug #4/#10, Add Spanish (es), improve French (fr) translations
359cc75 
* [iet:8994834][ci skip]
nfreear added a commit that referenced this issue Feb 26, 2018
@nfreear
Bug #10, add CHANGELOG; link from README [iet:8994834][ci skip]
706fd95
nfreear added a commit that referenced this issue Feb 28, 2018
@nfreear
Bug #10, Adopting lessc in package JSON [iet:8994834]
33db2fa
nfreear added a commit that referenced this issue Feb 28, 2018
@nfreear
Bug #10, add a "Put gaad-widget on your site" link [iet:8994834]
d22d2e1
nfreear added a commit that referenced this issue Mar 4, 2018
@nfreear
Bug #10, add a methods.trans() Javascript function [ci skip]
0522629 
* Plus, lots of small edits
nfreear added a commit that referenced this issue Apr 30, 2018
@nfreear
Bug #10, add gitlab-ci YAML [iet:8994834]
97fb46d 
* https://gitlab.com/nfreear/gaad-widget
nfreear added a commit that referenced this issue Apr 30, 2018
@nfreear
Bug #10, extend gitlab-ci YAML; add badge to README [iet:8994834]
0b82ff5
nfreear added a commit that referenced this issue Apr 30, 2018
@nfreear
Bug #10, fix - convert gitlab-ci back to a single job
39f83b0
nfreear added a commit that referenced this issue Apr 30, 2018
@nfreear
Bug #10, fix gitlab-ci YAML syntax - artifacts [iet:8994834]
6ceeb58
nfreear added a commit that referenced this issue Apr 30, 2018
@nfreear
Bug #10, Add dist/gaad-widget JS; data; prepare 3.2 release [iet:89…
7c26500 
…94834]
@nfreear nfreear closed this as completed May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nfreear