Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Node.js 11/12 #175

Merged
merged 1 commit into from May 28, 2019
Merged

Add support for Node.js 11/12 #175

merged 1 commit into from May 28, 2019

Conversation

pioug
Copy link
Collaborator

@pioug pioug commented May 27, 2019

@NaridaL NaridaL merged commit b0e8399 into nfroidure:master May 28, 2019
@pioug
Copy link
Collaborator Author

pioug commented May 29, 2019

Thanks you @NaridaL for reviewing! Do you think we can release a (major) update for gulp-icon-font now?

Same with the other packages, I'll be happy to help with all the chores 馃檶 (bump, triage issues/PR, small updates...)

@NaridaL
Copy link
Collaborator

NaridaL commented May 29, 2019

@pioug Does this need a major version? Is there anything other than the fact that gulp-ttf2woff2 no longer supports node 0.12? The package.json here says "node": ">= 6.11.1" anyway.

@pioug
Copy link
Collaborator Author

pioug commented May 30, 2019

Good point! We are dropping very old Node versions. I think we can bump a minor version since it doesn't affect the compatibility for this package 馃憤

@pioug
Copy link
Collaborator Author

pioug commented Jun 3, 2019

Thank you @nfroidure for inviting me to the repository! I bumped and tagged a new version https://github.com/nfroidure/gulp-iconfont/releases/tag/v10.0.3. Next is publishing on npm and I think we're good with Node 12 馃挦

Thanks for following up on my PRs 馃檶

@NaridaL
Copy link
Collaborator

NaridaL commented Jun 3, 2019

馃憤 Yeah, sorry I was waiting on feedback to nfroidure/gulp-svgicons2svgfont#40, which would also need changes here, but this works too :-D

I can publish to npm this evening unless @nfroidure gives you access there too.

@nfroidure
Copy link
Owner

Jut added you @pioug thank you both for taking time to update all that legacy :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants