Speed up dbench testing by installing RPMs and not building dbench from source #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to build dbench from source, it is already available from the CentOS Storage SIG in the testing repository. dbench installed from the RPM expects /usr/share/client.txt, but it is cleaner to pass it as a commandline argument. Signed-off-by: Niels de Vos <ndevos@redhat.com>
It seems that the dbench tests run in the current working directory, and not on the mounted NFS exports. Pass the --directory option to dbench so that the tests are executed over NFS and not in the local filesystem. Signed-off-by: Niels de Vos <ndevos@redhat.com>
dang
approved these changes
May 11, 2018
|
The manual started test-run at https://ci.centos.org/job/nfs_ganesha_dbench/344/ succeeded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to build dbench from source, RPMs are available.
While updating this test, I noticed that the dbench runs are on the local filesystem, and not on the NFS exports. The 2nd patch in this PR addresses that by creating a workdir for each test, and passing the
--directoryoption to thedbenchexecutable.