Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(c)make install things like nfs-ganesha-config.sh #188

Closed
kalebskeithley opened this issue Jul 10, 2017 · 3 comments
Closed

(c)make install things like nfs-ganesha-config.sh #188

kalebskeithley opened this issue Jul 10, 2017 · 3 comments

Comments

@kalebskeithley
Copy link
Contributor

See, e.g., nfs-ganesha/nfs-ganesha-debian#1 and the in-tree nfs-ganesha.spec-in.cmake (or the Fedora dist-git nfs-ganesha.spec) or https://github.com/nfs-ganesha/nfs-ganesha-debian/blob/jessie-nfs-ganesha-2.5/debian/rules

We have a growing list of miscellaneous files that don't get installed by make install and we have to hack up the package files to work around that. Not to mention that anyone installing by running `make install from their build tree will miss getting those files installed.

I.e.: log_rotate, dbus org.ganesha.nfsd.conf, nfs-ganesha-config.sh, mount.9P, etc., files.

@dang
Copy link
Contributor

dang commented Jul 11, 2017

I'm wondering about this. It's hard to imagine someone doing a full install from source and using systemd to manage it. They'll likely use packages instead. In addition, the more files we toss in various places around the filesystem, the harder it is do remove a ganesha that's been installed from source.

That said, I don't have a strong opinion, and it doesn't cause a problem for me, since I only ever install to a prefix, so deleting is easy.

@kalebskeithley kalebskeithley changed the title (c)make install things like nfs-ganesah-config.sh (c)make install things like nfs-ganesha-config.sh Jul 11, 2017
@kalebskeithley
Copy link
Contributor Author

nothing is going to clean up from a make install AFAIK.
The point is that (according to some anyway) that the packaging shouldn't have to "install" anything. It should be done by the make install that the packaging performs.
Packagers aren't necessarily as familiar with the software and any changes to files that need to be installed as we'd like them to be. The burden shouldn't be on them to make sure everything that needs to be installed is actually installed.

@ffilz
Copy link
Member

ffilz commented Jun 15, 2020

Closing as will not fix.

@ffilz ffilz closed this as completed Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants