Fix a portability issue in svc_dg_recv(). #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 6, 2013 14:05
Signed-off-by: Sachin Bhamare <sbhamare@panasas.com>
Signed-off-by: Sachin Bhamare <sbhamare@panasas.com>
malahal
referenced
this pull request
in malahal/ntirpc
Aug 28, 2015
Coverity CID 130080 (linuxbox2#1 of 1): Missing unlock (LOCK)
mattbenjamin
pushed a commit
that referenced
this pull request
Sep 2, 2015
Coverity CID 130080 (#1 of 1): Missing unlock (LOCK) Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
mattbenjamin
pushed a commit
that referenced
this pull request
Sep 2, 2015
Coverity CID 130080 (#1 of 1): Missing unlock (LOCK) Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
skmprabhu1
added a commit
to skmprabhu1/ntirpc-1
that referenced
this pull request
Jul 14, 2022
Fixed the following valgrind report by initializing 'buffer' to 0 in 'svc_dg_reply': ==2615== Syscall param sendmsg(msg.msg_control) points to uninitialised byte(s) ==2615== at 0x6651C6D: ??? (in /usr/lib64/libpthread-2.17.so) ==2615== by 0x6A8A9E1: svc_dg_reply (svc_dg.c:465) ==2615== by 0x6A88748: svc_sendreply (svc.c:549) ==2615== by 0x44CDF2: nfs_rpc_execute (nfs_worker_thread.c:1344) ==2615== by 0x44D447: worker_run (nfs_worker_thread.c:1562) ==2615== by 0x50C4FF: fridgethr_start_routine (fridgethr.c:550) ==2615== by 0x664AE24: start_thread (in /usr/lib64/libpthread-2.17.so) ==2615== by 0x6FC434C: clone (in /usr/lib64/libc-2.17.so) ==2615== Address 0x1360ce08 is on thread 17's stack ==2615== in frame nfs-ganesha#1, created by svc_dg_reply (svc_dg.c:407) Signed-off-by: Prabhu Murugesan <prabhu.murugeshan@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Size of 'sa_family_t' data type differs across platforms (2 bytes on Linux
x86_64 vs 1 byte on amd64 FreeBSD). Assigning a value to a variable of data type
sa_family_t thus requires an explicit cast to avoid the strict compile errors.
Signed-off-by: Sachin Bhamare sbhamare@panasas.com