Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to initial setup for developers #472

Closed
alanshaw opened this issue Sep 27, 2021 · 0 comments · Fixed by #1171
Closed

Improvements to initial setup for developers #472

alanshaw opened this issue Sep 27, 2021 · 0 comments · Fixed by #1171
Assignees
Labels
kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up topic/tg

Comments

@alanshaw
Copy link
Member

Fallout from #471

  • Clean up docker containers properly. When my configuration was not setup properly containers weren't being cleaned up. This needs to be fixed.
    • In pw-test.config.cjs, if we throw in beforeTests then afterTests is not run
  • Document somewhere that docker needs 8GB RAM for the postgres and postgrest docker containers to run in. I got "error 137" starting postgrest - this is because I only allowed 2GB of RAM for docker (I think maybe the default).
  • Rename env vars (suggestions shown...). These are currently very generic and there was no documentation for the values they should contain:
    • DATABASE_URL => POSTGREST_API_URL
    • DATABASE_TOKEN => POSTGREST_BASIC_AUTH_TOKEN
    • DATABASE_CONNECTION => POSTGRES_CONN_STRING
  • Add an npm script to setup a localtunnel for using local postgrest - the app needs to access a locally running database (or perhaps we should recommend setting up a free supabase account for this?).
@alanshaw alanshaw added kind/enhancement A net-new feature or improvement to an existing feature need/triage Needs initial labeling and prioritization labels Sep 27, 2021
@atopal atopal added P2 Medium: Good to have, but can wait until someone steps up and removed need/triage Needs initial labeling and prioritization labels Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up topic/tg
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants