Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/simple-dev #999

Merged
merged 27 commits into from Jan 25, 2022
Merged

Feat/simple-dev #999

merged 27 commits into from Jan 25, 2022

Conversation

hugomrdias
Copy link
Contributor

@hugomrdias hugomrdias commented Dec 19, 2021 •
edited

I have been working on our dev setup and im glad to announce that we can now run website and API without Cloudflare account
The only account we need now is a personal free magic.link nothing else!
Also the local docker compose setup includes ipfs cluster 🎉
No more tunnels, wrangler, personal cloudflare account and settings, cluster mocks or out of band cluster docker setup.

Merry Christmas 🎅 🎄

  • adds real cluster to local dev
  • removes wrangler dev with the help of miniflare
  • some other tweaks and improvements

@cloudflare-pages
Copy link

cloudflare-pages bot commented Dec 19, 2021 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: be8c35c
Status: ✅  Deploy successful!
Preview URL: https://542f3e18.nft-storage-1at.pages.dev

View logs

vasco-santos
vasco-santos requested changes Dec 22, 2021
View reviewed changes
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🎉

packages/api/db/reset.sql Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
packages/api/README.md Outdated Show resolved Hide resolved
packages/api/db/docker/docker-compose.yml Outdated Show resolved Hide resolved
packages/api/db/docker/docker-compose.yml Outdated Show resolved Hide resolved
packages/api/package.json Outdated Show resolved Hide resolved
@JeffLowe
Copy link
Contributor

@hugomrdias is this one completion of #472

@hugomrdias
Copy link
Contributor Author

@hugomrdias is this one completion of #472

Some of that yes but not all

@JeffLowe
Copy link
Contributor

JeffLowe commented Dec 22, 2021 •
edited

@hugomrdias I was checking a different PR and noticed login is broken on the CF preview links. I checked this preview link, and it has the same breakage (See console logs in screenshot).
Screen Shot 2021-12-22 at 11 21 30 AM
Could the cloudflare work have impact4ed the auth?
Steps to replicate: Open preview link in this pr. Click Login. Attempt to login with either magic link email or GitHub integration.
Result: Screen returns user to homepage in unauthenticated state. Console log shows above errors

@hugomrdias
Copy link
Contributor Author

@hugomrdias I was checking a different PR and noticed login is broken on the CF preview links. I checked this preview link, and it has the same breakage (See console logs in screenshot). Screen Shot 2021-12-22 at 11 21 30 AM Could the cloudflare work have impact4ed the auth? Steps to replicate: Open preview link in this pr. Click Login. Attempt to login with either magic link email or GitHub integration. Result: Screen returns user to homepage in unauthenticated state. Console log shows above errors

yes its probably because of the dev deploy override, those previews only worked because of a random db i had setup in supabase.
that will be properly fixed in a different way with unique sandboxed previews

@vasco-santos
Copy link
Member

For some reason, I can't use this branch on my local environment. I get the following error in the worker:

Access to fetch at 'http://localhost:9094/add?meta-size=12&local=true&stream-channels=false&raw-leaves=true&cid-version=1' from origin 'http://127.0.0.1:50863' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled

It also fails in web3-storage/web3.storage#847 but I don't know exactly why, it works in this repo CI

alanshaw
alanshaw approved these changes Jan 20, 2022
View reviewed changes
.github/workflows/api.yml Outdated Show resolved Hide resolved
packages/api/package.json Show resolved Hide resolved
packages/api/src/constants.js
typeof CLUSTER_BASIC_AUTH_TOKEN !== 'undefined'
? CLUSTER_BASIC_AUTH_TOKEN
: '',
basicAuthToken: CLUSTER_BASIC_AUTH_TOKEN,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes this global mandatory...but there is no basic auth by default...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is now with this setup, we already had issues in the past for not testing with auth. I think gozala even added auth to the cluster client tests

@hugomrdias hugomrdias merged commit 076270c into main Jan 25, 2022
@hugomrdias hugomrdias deleted the feat/simple-dev branch January 25, 2022 17:56
This was referenced Jan 26, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasco-santos vasco-santos vasco-santos approved these changes

@alanshaw alanshaw Awaiting requested review from alanshaw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hugomrdias @JeffLowe @vasco-santos @alanshaw