Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: CSP change breaks local JS loading #182

Closed
ikreymer opened this issue Aug 30, 2022 · 1 comment
Closed

Regression: CSP change breaks local JS loading #182

ikreymer opened this issue Aug 30, 2022 · 1 comment
Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization

Comments

@ikreymer
Copy link

ikreymer commented Aug 30, 2022 •
edited

The change in #176 ends up breaking loading of local JS.

The CSP was changed to contain:

connect-src https://polygon-rpc.com https://rpc.testnet.fantom.network

but it should include self:

connect-src 'self' https://polygon-rpc.com https://rpc.testnet.fantom.network

Otherwise, all local scripts within CID are broken, as per: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/connect-src
@ikreymer ikreymer added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Aug 30, 2022
@ikreymer
Copy link
Author

Fixed via #183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ikreymer