fix: wasm module loading #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses wasm module loading reported in #175 For details see https://github.com/WebAssembly/content-security-policy/blob/main/proposals/CSP.md#the-wasm-unsafe-eval-source-directive
Gozala
commented
Aug 22, 2022
Deploying with
|
| Latest commit: |
2d14087
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://19dd41b8.nftstorage-link.pages.dev |
| Branch Preview URL: | https://fix-wasm-loading.nftstorage-link.pages.dev |
Gozala
commented
Aug 22, 2022
packages/edge-gateway/src/gateway.js
Outdated
| @@ -537,7 +537,7 @@ function getTransformedResponseWithCustomHeaders(response) { | |||
|
|
|||
| clonedResponse.headers.set( | |||
| 'content-security-policy', | |||
| "default-src 'self' 'unsafe-inline' blob: data: ; form-action 'self' ; navigate-to 'self' " | |||
| "default-src 'self' 'unsafe-inline' 'unsafe-eval' blob: data: ; form-action 'self' ; navigate-to 'self' " | |||
There was a problem hiding this comment.
We have considered this in #172 (comment), but left it out. As it turns out leaving it out prevents WASM module loading which is not a desired behavior.
We could enable just wasm via unsafe-wasm-eval directive, however I don't see a good reason to disable js eval so I'm proposing this.
Gozala
commented
Aug 22, 2022
|
It should probably be: |
|
Thanks @ikreymer ! Yes, it won't inherit from default-src the 'self'. Adding it now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses wasm module loading reported in #175
For details see https://github.com/WebAssembly/content-security-policy/blob/main/proposals/CSP.md#the-wasm-unsafe-eval-source-directive