feat: edge gateway extend cdn resolution with r2 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
feat/edge-gateway-cdn-resolution-layer-with-r2
branch
from
5c1280c
to
3e95587
Compare
Deploying with
|
| Latest commit: |
5fd3f6d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0b0af933.nftstorage-link.pages.dev |
vasco-santos
force-pushed
the
feat/edge-gateway-cdn-resolution-layer-with-r2
branch
11 times, most recently
from
93a9bb7
to
311fb83
Compare
vasco-santos
force-pushed
the
feat/edge-gateway-cdn-resolution-layer-with-r2
branch
from
311fb83
to
9b4bada
Compare
alanshaw
reviewed
May 20, 2022
packages/edge-gateway/src/gateway.js
Outdated
| @@ -231,6 +232,36 @@ async function settleGatewayRequests( | |||
| ]) | |||
| } | |||
|
|
|||
| /* | |||
packages/edge-gateway/src/gateway.js
Outdated
Comment on lines
241
to
247
| * @param {string} cacheControl | ||
| */ | ||
| async function cdnResolution(request, env, cache, cacheControl) { | ||
| // Should skip cache if instructed by headers | ||
| if (cacheControl.includes('no-cache')) { | ||
| return undefined | ||
| } |
There was a problem hiding this comment.
Suggested change
| * @param {string} cacheControl | |
| */ | |
| async function cdnResolution(request, env, cache, cacheControl) { | |
| // Should skip cache if instructed by headers | |
| if (cacheControl.includes('no-cache')) { | |
| return undefined | |
| } | |
| */ | |
| async function cdnResolution(request, env, cache) { | |
| // Should skip cache if instructed by headers | |
| if ((request.headers.get('Cache-Control') || '').includes('no-cache')) { | |
| return undefined | |
| } |
alanshaw
approved these changes
May 20, 2022
This was referenced May 20, 2022
This was referenced Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds R2 as a first layer resolution (in CDN together with cache API). It also adds better header handling for previous convs
Closes #60